suhuruli commented on PR #57149: URL: https://github.com/apache/spark/pull/57149#issuecomment-5187670413
Narrowing this PR to **SCD Type 1 only** to keep it reviewable. The SCD Type 2 material - the `__START_AT` / `__END_AT` validity interval, `TRACK HISTORY ON`, and the Type 2 walkthrough - is removed here and will come as a follow-up under [SPARK-58570](https://issues.apache.org/jira/browse/SPARK-58570). The diff drops from 536 to 356 added lines. Everything from your review stands: keys and sequence values are still defined before use, the sequencing constraints are still documented, the examples still carry a genuine out-of-order event, and the two-run end-to-end walkthrough is unchanged. One deliberate choice worth flagging. I did not restore the old "SCD Type 1 is the only mode currently supported" wording, because that is no longer true on master - Type 2 landed in SPARK-58247 / SPARK-58261 / SPARK-58321. Instead, the two places where a reader would otherwise be misled - the `stored_as_scd_type` parameter and the `STORED AS SCD TYPE` clause, both of which accept `2` - say Type 2 is accepted and link SPARK-58570. Narrower scope for this PR, without the guide making a false claim in the meantime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
