sarutak commented on PR #57675: URL: https://github.com/apache/spark/pull/57675#issuecomment-5191572339
Thank you for the review, @HyukjinKwon. > A few executor-side / driver-attach paths remain directly untested: TaskSetManager.resourceOffer actually attaching the current credentials to the TaskDescription, and version monotonicity in UserCredentialManagerSuite Version monotonicity is now asserted in the token rotation test (added in the round 2 commit). It verifies callbacks receive versions 1, 2 in order. For `TaskSetManager.resourceOffer`, I agree a direct test would round out coverage. I plan to cover it in Sub-task 7 (integration tests) where the full credential flow is exercised end-to-end. > The PR description is the empty template The PR description should be filled in. Could you check again? It may have been a transient display issue after the force-push. The description includes the three delivery paths, versioned store design, security model, and test summary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
