Joorgem commented on PR #57608: URL: https://github.com/apache/spark/pull/57608#issuecomment-5197117369
Thanks @HyukjinKwon — fixed in c226815. `lineSep` is the accurate reference: default `\r`, `\r\n` and `\n` for reading, max one character, so "a line break" was loose. The `mode` row now names the option. I left the `multiLine` row saying "line breaks within quoted values", since that is the pre-existing sentence this PR only appends to — changing one and not the other seemed worse than leaving both consistent. Say the word and I'll make both read `lineSep`. @szehon-ho on the ordering: I can't control merge order, so I'd rather not leave it to luck. Both are ready — #57658 has your lgtm with the `<em>` nit now fixed (3203978), and this one is approved. **If #57658 lands first, nothing here needs changing.** If a committer would rather take this one alone, tell me and I'll fold the bullet correction in here and close it out of #57658 — I'm avoiding doing that pre-emptively because having the same edit in two open PRs would conflict whichever merges second. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
