planga82 commented on code in PR #55444:
URL: https://github.com/apache/spark/pull/55444#discussion_r3729208653


##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala:
##########
@@ -595,6 +599,31 @@ abstract class SQLQuerySuiteBase extends QueryTest with 
SQLTestUtils with TestHi
     }
   }
 
+  test("SPARK-56558: CTAS IF NOT EXISTS skips execution when table exists, " +

Review Comment:
   The idea was to test that the current behavior of "IF NOT EXISTS" was not 
broken with the changes, and the bug itself was tested in the other test. But I 
agree, it’s clearer to do it the way you say, and we avoid executer redundant 
permutations



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to