jubins commented on code in PR #57550:
URL: https://github.com/apache/spark/pull/57550#discussion_r3733010640
##########
python/pyspark/sql/tests/test_job_cancellation.py:
##########
@@ -37,6 +37,23 @@ def test_tags(self):
self.assertEqual(self.spark.getTags(), set())
self.spark.clearTags()
+ def test_invalid_tags(self):
Review Comment:
good catch, switched it to `set.discard` and added the valid-absent-tag case
here (mirroring the Scala test), so the mixin now locks the no-op contract in
both modes. thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
