AngersZhuuuu commented on code in PR #57716:
URL: https://github.com/apache/spark/pull/57716#discussion_r3733868267
##########
core/src/main/scala/org/apache/spark/memory/UnifiedMemoryManager.scala:
##########
@@ -459,12 +466,14 @@ object UnifiedMemoryManager extends Logging {
/**
* Return the total amount of memory shared between execution and storage,
in bytes.
*/
- private def getMaxMemory(conf: SparkConf): Long = {
+ private def getMaxMemory(conf: SparkConf, isDriver: Option[Boolean]): Long =
{
val systemMemory = conf.get(TEST_MEMORY)
val reservedMemory = conf.getLong(TEST_RESERVED_MEMORY.key,
if (conf.contains(IS_TESTING)) 0 else RESERVED_SYSTEM_MEMORY_BYTES)
val minSystemMemory = (reservedMemory * 1.5).ceil.toLong
- if (systemMemory < minSystemMemory) {
+ val checkDriverMemory = isDriver.isEmpty || isDriver.contains(true)
+ val checkExecutorMemory = isDriver.isEmpty || isDriver.contains(false)
Review Comment:
How about current?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
