uros-b opened a new pull request, #57847:
URL: https://github.com/apache/spark/pull/57847
### What changes were proposed in this pull request?
Rewrites the private `getBool` in `CSVOptions` and `XmlOptions` to match the
shape of the sibling option accessors:
```scala
private def getBool(paramName: String, default: Boolean = false): Boolean
= {
val paramValue = parameters.get(paramName)
paramValue match {
case None => default
case Some(null) => default
case Some(value) => value.toLowerCase(Locale.ROOT) match {
case "true" => true
case "false" => false
case _ => throw
QueryExecutionErrors.paramIsNotBooleanValueError(paramName)
}
}
}
```
### Why are the changes needed?
`getChar` and `getInt` in `CSVOptions` already match on
`parameters.get(paramName)` and handle the missing and null cases as `case
None` and `case Some(null)`, while `getBool` was an if/else-if chain over
`parameters.getOrElse(paramName, default.toString)`. Besides being
inconsistent, that form converts the default to a string only to parse it
straight back, and calls `toLowerCase` twice on the `false` and error paths.
`XmlOptions` carried a byte-identical copy of the old method, so both are
updated together to keep them in sync rather than leaving them divergent.
### Does this PR introduce _any_ user-facing change?
No. Behavior is unchanged for every input: an absent key yields the default,
an explicit `null` value yields the default, `true`/`false` are accepted
case-insensitively via `Locale.ROOT`, and any other value throws the same error
with the same parameter as before.
### How was this patch tested?
Behavior-preserving change covered by the existing CSV and XML option tests.
Equivalence with the previous implementation was checked case by case across
absent keys, explicit nulls, mixed-case `true`/`false`, the empty string, and
other invalid values, for both `default` values.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
