bojana-db opened a new pull request, #57855:
URL: https://github.com/apache/spark/pull/57855
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Make the optional `create_if_missing` argument of `variant_set` (and
`try_variant_set`) a constant-only argument. `VariantSet.checkInputDataTypes`
now rejects a non-foldable `create_if_missing` with
`DATATYPE_MISMATCH.NON_FOLDABLE_INPUT`.
### Why are the changes needed?
`create_if_missing` is a mode flag that controls the operation's behavior,
not per-row data, so it should be a constant.
### Does this PR introduce _any_ user-facing change?
Yes, within the unreleased `master`/`branch-4.x` line only
(`variant_set`/`try_variant_set` are new in 4.3.0 and not yet released; there
is no change relative to any released Spark version).
### How was this patch tested?
Unit tests:
- `VariantExpressionSuite`: asserts `checkInputDataTypes().isFailure` for a
non-foldable `create_if_missing`, covering both `variant_set` and
`try_variant_set`. Also updated an existing test that previously exercised a
per-row (`BoundReference`) `create_if_missing` so it uses a constant flag (the
dynamic `path` coverage is retained).
- `VariantSuite`: an end-to-end SQL case asserting
`intercept[AnalysisException].getCondition ==
"DATATYPE_MISMATCH.NON_FOLDABLE_INPUT"`.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
