cloud-fan commented on code in PR #57754:
URL: https://github.com/apache/spark/pull/57754#discussion_r3737582982
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ui/SparkConnectServerPage.scala:
##########
@@ -179,6 +181,80 @@ private[ui] class SparkConnectServerPage(parent:
SparkConnectServerTab)
content
}
+
+ /** Generate live ML cache statistics for active Spark Connect sessions. */
+ private def generateMLCacheStatsTable(request: HttpServletRequest):
Seq[Node] = {
+ val cacheStatuses = parent.getMLCacheStatuses.filter(_._2.models.nonEmpty)
Review Comment:
This filter prevents the UI from showing the promised unused-cache state:
before the first model is registered, or after the cache is cleared, the model
list is empty and the whole section disappears. Please retain session-level
statuses with empty model lists and render `Not used`; the no-live-manager path
should likewise render the documented unavailable state instead of silently
omitting it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]