dongjoon-hyun opened a new pull request, #493: URL: https://github.com/apache/spark-connect-swift/pull/493
### What changes were proposed in this pull request? This PR aims to test timezone variations in the `timestamp` test of `DataFrameTests` by removing `TODO(SPARK-52747)` and verifying the behavior explicitly under multiple session timezones. - A timestamp literal with a timezone offset (`Z`) is verified to denote a fixed instant independent of `spark.sql.session.timeZone` (`UTC` and `America/Los_Angeles`). - A timestamp literal without a timezone offset is verified to be interpreted in the session timezone. - The original `spark.sql.session.timeZone` setting is restored at the end of the test. ### Why are the changes needed? `TODO(SPARK-52747)` was added by SPARK-52744 as a workaround when the `MacOS` integration test started to run a Spark Connect server directly on the host whose timezone is not `UTC`. This is not a server behavior change but the documented Spark semantics: a timestamp literal without a timezone offset is interpreted in the session timezone. Since the Swift client converts Arrow timestamp values into absolute instants (`Date(timeIntervalSince1970:)`), it already handles timezone variations correctly. This PR closes the TODO by testing those semantics deterministically regardless of the server's host timezone. ### Does this PR introduce _any_ user-facing change? No. This is a test-only change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Fable 5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
