sarutak opened a new pull request, #57877: URL: https://github.com/apache/spark/pull/57877
### What changes were proposed in this pull request? Follow-up to #57675 addressing non-blocking review comments from @dongjoon-hyun: 1. **Document missed-update window for late-registering executors**: Added comments explaining the narrow window where a renewal broadcast (vN+1) could arrive between an executor's `SparkAppConfig` reply (vN) and its registration in `executorDataMap`, and noting that the `TaskDescription` path covers this case. 2. **Document why initial credential application uses `set()` instead of `updateIfNewer()`**: The store is guaranteed null at executor startup (before any RPC or task is received), so the version guard comparison is unnecessary. 3. **Add `@volatile` to `MockExecutorRpcEndpointRef` test fields**: `decommissionReceived` and `receivedUserCredentials` are written by the RPC dispatcher thread and read by the test thread inside `eventually`, so visibility must be guaranteed. 4. **Clarify TaskDescription overhead comment**: Qualified as "in-memory overhead at any instant" to distinguish from cumulative network transfer cost. ### Why are the changes needed? These address non-blocking review feedback on #57675 to improve code documentation and test correctness. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? Kiro CLI / Claude -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
