uros-b commented on code in PR #57884:
URL: https://github.com/apache/spark/pull/57884#discussion_r3746877119


##########
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionJobTaggingAndCancellationSuite.scala:
##########
@@ -160,8 +160,8 @@ class SparkSessionJobTaggingAndCancellationSuite
         }
 
         override def onJobEnd(jobEnd: SparkListenerJobEnd): Unit = {
-          sem.release()
           jobEnded.incrementAndGet()
+          sem.release()

Review Comment:
   Let's add a short comment on the ordering, to keep someone from swapping 
them back in the future



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to