ganeshashree commented on code in PR #57708:
URL: https://github.com/apache/spark/pull/57708#discussion_r3749502141
##########
core/src/main/scala/org/apache/spark/memory/MemoryManager.scala:
##########
@@ -62,6 +62,14 @@ private[spark] abstract class MemoryManager(
protected[this] val offHeapStorageMemory =
(maxOffHeapMemory * conf.get(MEMORY_STORAGE_FRACTION)).toLong
+ /**
+ * The maximum number of consumers listed individually in the per-consumer
memory breakdown
+ * attached to an UNABLE_TO_ACQUIRE_MEMORY error. Read by
[[TaskMemoryManager]]. See
Review Comment:
Kept `an` here. The repo articles these all-caps tokens by how the leading
word sounds, e.g., an `INVALID_VARIANT_CAST` / `an EOF_RECORD` vs. `a
USER_RAISED_EXCEPTION` / `a MANAGED_TABLE`. It also matches the existing
config description in `package.scala` ("`...attached to an
UNABLE_TO_ACQUIRE_MEMORY error`"). Please let me know whether you still prefer
`a`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
