cloud-fan commented on PR #57854: URL: https://github.com/apache/spark/pull/57854#issuecomment-5243356728
Thanks for the follow-up review. I addressed the remaining actionable comments in befbcb982ef: - Documented the tri-state return value of `stop_local_connect_server()`. - Made the inconclusive `--stop` path exit with status 1, so scripts can distinguish it from the successful idempotent "no server" case, and added a regression test. - Cleared the fabricated discovery record at the end of the inconclusive-probe test so `tearDown` does not inspect PID 12345 on the host. I left the Windows behavior unchanged. Starting this managed server is explicitly POSIX-only, and clearing discovery where the process cannot be inspected would weaken the stale-PID safety guarantee. Local syntax validation passed. The PySpark test runner started successfully, but this environment skipped the suite because pandas >= 2.2.0 is not installed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
