szehon-ho commented on code in PR #57727:
URL: https://github.com/apache/spark/pull/57727#discussion_r3752498706
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/SupportsRuntimeV2Filtering.java:
##########
@@ -28,8 +28,8 @@
* filter initially planned {@link InputPartition}s using predicates Spark
infers at runtime.
* This interface is very similar to {@link SupportsRuntimeFiltering} except
it uses
* data source V2 {@link Predicate} instead of data source V1 {@link Filter}.
- * {@link SupportsRuntimeV2Filtering} is preferred over {@link
SupportsRuntimeFiltering}
- * and only one of them should be implemented by the data sources.
+ * {@link SupportsRuntimeV2Filtering} is preferred over {@link
SupportsRuntimeFiltering}.
+ * Only one runtime filtering interface should be implemented by a data source.
Review Comment:
You are right, I moved the sentence instead of fixing it. Applied your
wording on `SupportsRuntimeV2Filtering`, plain text for
`SupportsRuntimeCatalystFiltering` for the reason you give.
I made the copy on `SupportsRuntimeCatalystFiltering` match, since your
second point applies there too: it is enforced now, not advice. From that page
it can name both `SupportsRuntimeV2Filtering` and `SupportsRuntimeFiltering`
explicitly, so a reader does not have to work out the inheritance for
themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
