Spenserrrr commented on PR #57912: URL: https://github.com/apache/spark/pull/57912#issuecomment-5247611643
Hi @zhengruifeng! This is SPARK-58630 (copysign) under the SPARK-58532 umbrella. I model it on your fmod PR (#57784), which is a _copysign_func helper + a dedicated edge test. I'll also keep an eye on the CI to confirm the new test `test_np_copysign` actually passes. Could you take a look when you have a moment? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
