HyukjinKwon commented on PR #57899:
URL: https://github.com/apache/spark/pull/57899#issuecomment-5248046210
Ran an Isaac Review pass over the current head (2a8cde43). One nit, no
blocking or non-blocking findings — the change is a faithful, well-tested
extension of the merged SPARK-27052 lift, and all prior review threads verify
resolved in the tree.
**Nit — dangling Scaladoc link** in `ExtractPythonUDFFromLambda.scala:45`:
The class doc still references
`[[PythonEvalType.SQL_ARROW_ELEMENTWISE_UDF]]`, but this PR removed the
`PythonEvalType` import (the rule now calls
`PythonUDF.liftedElementwiseEvalType`). Scaladoc resolves `[[...]]` through the
file's imports and package, so the unqualified name no longer binds — unlike
the sibling `[[PythonUDF.liftedElementwiseEvalType]]`, which resolves via the
`catalyst.expressions._` wildcard. Re-adding the import would just trip the
unused-import check.
Fully-qualify the class instead (and, since `PythonEvalType` is a Java
class, link the class rather than deep-linking the static field):
```
* [[org.apache.spark.api.python.PythonEvalType]]'s
SQL_ARROW_ELEMENTWISE_UDF, while a scalar pandas / Arrow UDF (and its iterator
```
Low severity: `org.apache.spark.sql.execution` is excluded from unidoc so
this never renders publicly, but it's a broken cross-reference the PR
introduces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
