nchammas commented on PR #57871: URL: https://github.com/apache/spark/pull/57871#issuecomment-5255006633
> * In the sdist-install scenario (`in_spark=False` with `deps/` present), `JARS_PATH` remains an empty list `[]`, which gets passed into `InstallPath(source: str, ...)`. Harmless at runtime since `INSTALL_PATHS` is only iterated when `in_spark` is true, but it contradicts the declared type. I think we should refactor how we build `JARS_PATH` (maybe move the logic into a helper function), but I'll leave that for a future PR since it's independent of the cleanup here. The type mismatch is unfortunate but it's harmless in this case. > * Silently skipping missing targets also drops the signal that staging was partial; a one-line note to stderr when skipping could be worth considering. That's fair. I reverted the behavior change to just fail as it did before. I've updated the PR description accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
