srielau commented on code in PR #57900:
URL: https://github.com/apache/spark/pull/57900#discussion_r3764178625
##########
common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:
##########
@@ -1410,6 +1410,9 @@ public void testInitCap() throws SparkException {
assertInitCap("ÄBĆΔE", UNICODE_CI, "Äbćδe");
assertInitCap("êéfgh", "AF_CI_AI", "Êéfgh");
assertInitCap("öoAÄ", "DE_CI_AI", "Öoaä");
+ assertInitCap("erik ijzermans", "NL", "Erik IJzermans");
+ assertInitCap("erik ijzermans", "NL_CI", "Erik IJzermans");
+ assertInitCap("erik ijzermans", UNICODE, "Erik Ijzermans");
Review Comment:
```suggestion
assertInitCap("john ijzermans", UNICODE, "John Ijzermans");
```
By request of said ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
