j1wonpark commented on PR #57831: URL: https://github.com/apache/spark/pull/57831#issuecomment-5293682745
No problem. Reverted to the sqlState override with the guardrails from this thread; names and messages are untouched, so the branch-4.0 cross-version concern is gone. Details are in the updated description, including the new `SparkThrowableSuite` check that fails any sub-condition `sqlState` outside the documented allowlist (verified to fail on an injected override). What's left, as I see it: - PySpark (for the cc above): nothing to change in this PR. `python/pyspark/errors/error-conditions.json` has no `INVALID_HANDLE`, and Connect Python clients take the SQLSTATE from server metadata, so released clients receive `08003` without a code change. The local reader's resolution is #57887's territory. - 4.3: the migration note targets 4.3, so this needs the branch-4.3 cherry-pick at merge time. - Compatibility layer: I can file a follow-up JIRA to track the design discussed above. The exception is built to be removable: drop the three overrides, shrink the allowlist, and the check enforces the default again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
