qlong commented on code in PR #57956:
URL: https://github.com/apache/spark/pull/57956#discussion_r3786435123
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PullOutVariantExtractions.scala:
##########
@@ -177,11 +177,20 @@ object PullOutVariantExtractions extends
Rule[LogicalPlan] {
case _ => false
}
+ private def isJoinHoistable(e: Expression): Boolean = {
Review Comment:
One more on this gate. When e.throwable becomes true in the future, is
PUSH_VARIANT_INTO_SCAN_DEFER_CAST_ERROR the right gate?
1. For both CombineFilers and PushPredicateThroughJoin, they stop when
throwable is true. But here it would continue to hoist if
PUSH_VARIANT_INTO_SCAN_DEFER_CAST_ERROR is true.
2. If we decide to continue use PUSH_VARIANT_INTO_SCAN_DEFER_CAST_ERROR as
the gate, we need change its doc when e.throwable is turee.
Nonblocking, but I think we should add a comment here, or drop the check on
PUSH_VARIANT_INTO_SCAN_DEFER_CAST_ERROR and design the right switch when
e.throwable is true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
