Spenserrrr commented on PR #57973: URL: https://github.com/apache/spark/pull/57973#issuecomment-5298124997
Thanks @nchammas! I reproduce the before and after comparison in both scripts, and the packaged output is unchanged. - setup.py dist (first script): built the classic / connect / client sdists on the base commit and again with the patch, then diffed them recursively at the byte level (diff -ruN). The only files that differ are MANIFEST.in and setup.py, which are the files this PR edits. Every other file is byte-for-byte identical. - ./dev/make-distribution.sh --pip (second script): repeated the before/after build through the full release path, which additionally stages the LICENSE/NOTICE files and the assembly jars into the sdists. The three packages' packaged filesets come out identical before and after there too. The changes also look good to me. Nice cleanup. cc @gaogaotiantian -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
