yyanyy commented on code in PR #57865:
URL: https://github.com/apache/spark/pull/57865#discussion_r3799412566
##########
sql/core/src/main/scala/org/apache/spark/sql/classic/DataFrameWriter.scala:
##########
@@ -354,13 +358,13 @@ final class DataFrameWriter[T] private[sql](ds:
Dataset[T]) extends sql.DataFram
}
private def insertIntoCommand(catalog: CatalogPlugin, ident: Identifier):
LogicalPlan = {
- import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
-
- val table = catalog.asTableCatalog.loadTable(ident,
getWritePrivileges.toSet.asJava) match {
+ val tableOptions = new CaseInsensitiveStringMap(extraOptions.toMap.asJava)
+ val table = CatalogV2Util.getTableForWrite(
Review Comment:
thanks for the catch! moved the validation after `V1Table` so that V1
options remain ignored as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
