srielau commented on PR #58059: URL: https://github.com/apache/spark/pull/58059#issuecomment-5322494418
Folding this into #58033. I verified with a throwaway probe that every path here already works on the foundation branch with no code from this PR: `createDataFrame` from an RDD pads and rejects oversize, `.as[String]`/`.map` see the padded value, `collect()` returns the padded string, `groupBy` keys on it, and a Scala UDF with a `String` parameter fed a `CHAR(5)` column receives the padded value. What actually unlocks these surfaces is the change to `failIfHasCharVarchar` in #58033 (on master it rejected CHAR/VARCHAR outright, never consulting `preserveCharVarcharTypeInfo`). So these tests belong with that gate change rather than in a PR of their own. Carried over as 5a51ba21808. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
