sarutak commented on PR #58041: URL: https://github.com/apache/spark/pull/58041#issuecomment-5323959576
Thank you for the review, @dongjoon-hyun. I've removed the non-ASCII characters from comments (replaced `'é'` and `'世'` with their code point references `U+00E9` and `U+4E16`). Regarding the string literals (`"café"`, `"session世"`): per [AGENTS.md L23](https://github.com/apache/spark/blob/95d93a0116ac5e4a7229a87dfa7b7c85638e3f90/AGENTS.md?plain=1#L23): > String literals may contain non-ASCII when the content requires it (error messages, **test data**, etc.) These are test data — the tests verify that non-ASCII characters are correctly rejected as STS session names. Recent commits merged after the AGENTS.md rule was added also use non-ASCII directly in test data string literals: - [#57272](https://github.com/apache/spark/pull/57272) (SPARK-58096): `Row("且", 3), Row("丕", 2), Row("世", 1)` in [`ApproxTopKSuite.scala`](https://github.com/apache/spark/blob/b53129341495ce93c6efc22232a4eeaea8d003b8/sql/core/src/test/scala/org/apache/spark/sql/ApproxTopKSuite.scala) - [#57156](https://github.com/apache/spark/pull/57156) (SPARK-58061): `checkAppend("""{"你好": [1]}""", ...)` and `Literal("café")` in [`VariantExpressionSuite.scala`](https://github.com/apache/spark/blob/1795b3bfb147d908daed3f7b8f04b181358e723f/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/variant/VariantExpressionSuite.scala) I've kept the direct characters in the string literals for readability because the test intent ("this non-ASCII input must be rejected") is immediately clear when you can see the actual character. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
