Github user kanzhang commented on the pull request:
https://github.com/apache/spark/pull/6774#issuecomment-112159412
> And as I said numerous times, whether to use env variables or something
else to propagate a secret has absolutely zero to do with whether you can
support per-app secrets.
No disagreement on that statement. My comment only concerns the
implementation aspects of it. If stdin is a viable approach and we agree to use
it for per-app secret support now, it gives me justification to introduce
`appSecret` in `ApplicationDescription` and `DriverDescription` and handle all
filtering and setting up app secrets when we generate them, which I think is
the way to go when we add per-app secret support, even if we continue to use
the current env variable approach. No need to do the same at a lower-level like
`buildLocalCommand`, as it is now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
