psavalle commented on code in PR #56516:
URL: https://github.com/apache/spark/pull/56516#discussion_r3802436321
##########
core/src/main/scala/org/apache/spark/resource/ResourceProfileManager.scala:
##########
@@ -139,13 +139,43 @@ private[spark] class ResourceProfileManager(sparkConf:
SparkConf,
}
// do this outside the write lock only when we add a new profile
if (putNewProfile) {
- // force the computation of maxTasks and limitingResource now so we
don't have cost later
- rp.limitingResource(sparkConf)
- logInfo(log"Added ResourceProfile id: ${MDC(LogKeys.RESOURCE_PROFILE_ID,
rp.id)}")
- listenerBus.post(SparkListenerResourceProfileAdded(rp))
+ onProfileAdded(rp)
}
}
+ /**
+ * Get the registered ResourceProfile whose resources are equal to the given
one, registering
+ * the given profile first if no equivalent one exists yet.
+ */
+ def getOrAddEquivalentProfile(rp: ResourceProfile): ResourceProfile = {
+ isSupported(rp)
+ var addedProfile: Option[ResourceProfile] = None
+ val resolvedProfile = {
+ writeLock.lock()
+ try {
+ resourceProfileIdToResourceProfile.collectFirst {
Review Comment:
Switched to checking with a read lock first, and existing mappings (incl. ID
0) are never overwritten now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
