cloud-fan commented on code in PR #58037:
URL: https://github.com/apache/spark/pull/58037#discussion_r3805738741


##########
docs/sql-ref-syntax-ddl-create-table-datasource.md:
##########
@@ -78,6 +78,14 @@ as any order. For example, you can write COMMENT 
table_comment after TBLPROPERTI
 
     Specifies buckets numbers, which is used in `CLUSTERED BY` clause.
 
+* **EXTERNAL**
+
+    Table is defined using the path provided as `LOCATION`, does not use 
default location for this table.
+    Dropping an external table removes catalog metadata and leaves the data 
files in place.
+    `CREATE EXTERNAL TABLE` for a data source table must include `LOCATION` or 
an equivalent path option.

Review Comment:
   **Non-blocking:**
   
   Please remove the path-option alternative and use `LOCATION` in the 
`student_ext` example. Parquet uses V1 by default, where `OPTIONS (PATH ...)` 
remains a storage property rather than `tableSpec.location`; with `EXTERNAL` 
set, `SessionCatalog.createTable` then rejects the table because 
`storage.locationUri` is empty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to