qlong commented on PR #58050: URL: https://github.com/apache/spark/pull/58050#issuecomment-5337259565
Thanks @viirya for updating the doc. Looking more closely at my test run against tpcds (SF=5) workload, I also noticed around 3% performance degradation when the flag is on, which is consistent with your own benchmark test. My test also runs on my laptop so that degradation could be just noise. Given the narrow applicability of this optimization, wondering if we should disable it by default if the 3% degradation turns out to be consistent? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
