viirya commented on PR #58097: URL: https://github.com/apache/spark/pull/58097#issuecomment-5348578745
Thanks again, @dongjoon-hyun -- another very sharp pass. All ten are addressed in a new commit; the two you flagged as real (the uninterruptible reader and the unscoped `RemoveShuffle`) plus the identity-guard and the cross-context rendezvous are the substantive ones, the rest are the allocation/config/comment/coverage cleanups. Replies inline. On the not-behind-the-flag one specifically: you are right, thank you -- that was mine to catch and I missed it. The cleaner arm is now gated on a tracker-less pipelined manager being active, so a feature-off deployment sees no extra `RemoveShuffle` or `shuffleCleaned`. CI is running on the new commit; I will confirm green when it finishes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
