srielau commented on PR #58132: URL: https://github.com/apache/spark/pull/58132#issuecomment-5347036878
Re-review remaining items: 1. **CI** -- not green yet. Fork Build for `4673559` is queued/in progress: https://github.com/srielau/spark/actions/runs/32291730651 (`Check changes` passed; remaining jobs still queued). The earlier Build on this branch was cancelled by the follow-up push. Local runs of `SparkConnectJdbcDataTypeSuite`, `SparkConnectDatabaseMetaDataSuite`, and `SparkMetadataOperationSuite` are still blocked here. Those three suites remain the merge gate. 2. **PR description** -- refreshed: `CHAR_OCTET_LENGTH`, `getTypeInfo` CHAR/VARCHAR rows, table `getColumns`, and the How-tested list now match `4673559`. 3. **Octet length vs UTF-8 bytes** -- called out in What/Why/user-facing. Helpers already document that Spark reports character length `n` (Connect 0 / HS2 null for unbounded STRING). No production change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
