Spenserrrr opened a new pull request, #58143:
URL: https://github.com/apache/spark/pull/58143

   ### What changes were proposed in this pull request?
   
   Add `PyArrowArrayFromPandasTypeNestedTests` for 
`pa.Array.from_pandas(series, type=..., safe=...)` with the nested target types 
`to_arrow_type` builds (`list<element>`, `map`, `struct`), alongside the 
existing scalar class. Four nested source rows are added to the shared 
inventory (a child-overflow list and struct, and homogeneous dicts for the map 
targets), so the default and mask goldens record their baseline.
   
   ### Why are the changes needed?
   
   The nested `from_pandas` direction was uncovered. The pinned behavior: 
`from_pandas` does not propagate `safe=` into a nested child, so an overflowing 
child value raises under both `safe=True` and `safe=False`, whereas the same 
overflow at the top level (the scalar tests) raises only under `safe=True`. The 
safe and unsafe goldens therefore match; both are kept so a future pyarrow that 
honors `safe=` in children fails loudly.
   
   ### Does this PR introduce any user-facing change?
   
   No (test-only).
   
   ### How was this patch tested?
   
   New golden tests. Swept pyarrow 18-25 x pandas 2/3: 16/16 pass, no overrides.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to