nchammas commented on code in PR #58219:
URL: https://github.com/apache/spark/pull/58219#discussion_r3838860918
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -582,7 +582,7 @@ private[sql] object QueryExecutionErrors extends
QueryErrorsBase with ExecutionE
def unableToCreateDatabaseAsFailedToCreateDirectoryError(
dbDefinition: CatalogDatabase, e: IOException): Throwable = {
new SparkException(
- errorClass = "_LEGACY_ERROR_TEMP_2033",
+ errorClass = "UNABLE_TO_CREATE_DATABASE",
Review Comment:
This error condition is more general than the actual failure path here. Why
not `UNABLE_TO_CREATE_DATABASE_DIRECTORY`?
(Unfortunately, the code still uses "error class" in many places to refer to
what is correctly called an "error condition".)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
