ganeshashree opened a new pull request, #58238:
URL: https://github.com/apache/spark/pull/58238
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'common/utils/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Stream-stream left semi and left outer joins rely on the left-side state
being evicted by the watermark, but the analyzer did not require the watermark
to be placed where that eviction can happen. This adds a shared analyzer check,
`checkStreamStreamJoinWatermarkPlacement`, with two requirements:
(1) left-state eviction for both types (the equi eviction key must be
watermarked, or the range bound must sit between watermarked attributes on both
sides);
(2) for left outer only, both eviction-ordinal join keys must be watermarked
so a late row cannot invalidate an already-emitted unmatched row. The new
helpers mirror the runtime's own attribute selection so the analyzer rejects
exactly the placements the runtime cannot honor.
It is gated by a kill switch,
`spark.sql.streaming.join.stricterWatermarkRequirements.enabled` (default
true), to restore the previous behavior. This is the shared-code fix split out
of #57813 (SPARK-58611, left anti).
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
With only the right side watermarked, or the watermark on the wrong join-key
ordinal or an unrelated attribute, the runtime builds no left-eviction
predicate. Left outer then silently drops its unmatched output, and left semi
state grows without bound. These placements should be rejected at analysis time
rather than run incorrectly.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
new features, bug fixes, or other behavior changes. Documentation-only updates
are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. Some stream-stream left semi and left outer queries that previously ran
now fail with an `AnalysisException` explaining the required watermark
placement. The behavior can be reverted with
`spark.sql.streaming.join.stricterWatermarkRequirements.enabled=false`.
Documented in the Structured Streaming migration guide (4.3 to 4.4).
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions
for the consistent environment, and the instructions could accord to:
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Added analyzer tests in `UnsupportedOperationsSuite` (range both-sides,
right-only, unrelated attribute, constant and anti-monotonic bounds, multiple
event-time columns, one-sided and both-sided equi keys, composite keys,
kill-switch fallback) and runtime tests in `StreamingJoinSuite` for left outer
and left semi. Ran locally: `UnsupportedOperationsSuite` (261) and
`StreamingOuterJoinWithoutVCFSuite` + `StreamingLeftSemiJoinWithoutVCFSuite`
(74), all pass.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Generated-by: Claude Code (Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
