ganeshashree commented on PR #57813: URL: https://github.com/apache/spark/pull/57813#issuecomment-5391302615
#58238 (SPARK-58904) is the split-out shared fix from this PR's review discussion. It adds a common analyzer check, `checkStreamStreamJoinWatermarkPlacement`, that enforces correct watermark placement for stream-stream left semi and left outer joins: the left-side state must be evictable (the equi eviction key must be watermarked, or the range bound must sit between watermarked attributes on both sides), and for left outer both eviction-ordinal join keys must be watermarked so a late row cannot invalidate an already-emitted unmatched row. It is gated by a kill switch, `spark.sql.streaming.join.stricterWatermarkRequirements.enabled` (default true). Once #58238 lands, I will rebase this PR on top of it and scope it down to left anti only, adding left anti as one more case in that shared check (always enforced, since it is newly supported) rather than the current left-anti-specific handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
