Yicong-Huang commented on PR #58198: URL: https://github.com/apache/spark/pull/58198#issuecomment-5401504604
@nchammas thanks so much for the suggestion, this is really the shape I was hoping for. I'd held off at first because it's a fairly big change to the script and I wasn't sure it would be welcome, but since you're raising the same concern I was glad to go ahead with it. push, the GitHub close/comment, and the JIRA writes now each go through a client with a Production and a DryRun subclass, and main() constructs the DryRun ones when --dry-run is set, so all the dry-run behavior lives in those subclasses. Please let me know if the structure isn't quite what you had in mind, happy to adjust. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
