ganeshashree commented on code in PR #58005:
URL: https://github.com/apache/spark/pull/58005#discussion_r3854360437
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ApplyDefaultCollation.scala:
##########
@@ -440,6 +443,18 @@ object ApplyDefaultCollation extends Rule[LogicalPlan] {
private def hasDefaultStringCharOrVarcharType(dataType: DataType): Boolean =
dataType.existsRecursively(isDefaultStringCharOrVarcharType)
+ /**
+ * A [[StringType]] that was written explicitly -- a distinct instance
rather than the default
Review Comment:
Done. Narrowed the wording at all cited sites,
`ApplyDefaultCollation.scala`, `DefaultCollationTypeCoercion.scala`, and the
three .sql sites (`jsonExpressions.scala` `JSON_VALUE/JSON_QUERY/JSON_ARRAY`).
The comments now say only an explicitly collated STRING is a distinct instance;
a plain RETURNING STRING is the StringType companion (per
`DataTypeAstBuilder`), indistinguishable from omission and recolored like it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
