zhengruifeng commented on PR #58278: URL: https://github.com/apache/spark/pull/58278#issuecomment-5420948896
Hi @dongjoon-hyun, thank you for the detailed review. I addressed the comments and replied to each thread. The PR now uses a pre-sized `java.util.HashMap`, hoists the broadcast dereference outside the token loop, removes the sentinel/helper changes, and adds strict-Kryo registration coverage. I also added the lookup, heap, Java serialization, and Kryo comparison to the benchmark summary above. Could you please take another look when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
