RamonZhou commented on code in PR #58264:
URL: https://github.com/apache/spark/pull/58264#discussion_r3866663391
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectConfigHandler.scala:
##########
@@ -85,6 +85,10 @@ class SparkConnectConfigHandler(responseObserver:
StreamObserver[proto.ConfigRes
operation.getPairsList.asScala.iterator.foreach { pair =>
val (key, value) = SparkConnectConfigHandler.toKeyValue(pair)
try {
+ // Reject a write that would leave the session's Python worker
environment invalid, before
+ // it is stored. Inside the try so that a `silent` request reports it
as a warning, the way
+ // it reports any other rejected write.
+ PythonWorkerEnvironment.validateConfigChange(conf, key, value)
Review Comment:
Fixed. Silent warning now drops the value: `s"Failed to set $key due to
${e.getMessage}"`. Applies to every conf key, not just our prefix, since any
value can be a secret and this handler already redacts on read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
