HyukjinKwon opened a new pull request, #63:
URL: https://github.com/apache/spark-connect-rust/pull/63
### What changes were proposed in this pull request?
Remove compiler-flagged dead Rust code (no behavior change):
- `ml.rs`: drop the unused `crate::session::SparkSession` module import
(it's only
used by the tests, so it now lives in the test module), and drop the
`input_col` / `output_col` fields of `StandardScalerModel` - the fitted
model
never reads them (it transforms via its operator/plan; the `StandardScaler`
estimator keeps its own copies), so they were redundant storage.
- `session.rs`: drop the unused `use arrow::array::*;` glob in
`rows_to_arrow_ipc`.
Deliberately **not** removed: `Observation`'s `dataframe` / `set_dataframe` /
`set_metrics` and `ProfileResult.metadata` are scaffolding for not-yet-wired
features (observed-metric collection / profile-metadata display), and
`ProfileResult.metadata` in particular is populated from real server
responses at
its call site. Deleting these would erase intended structure and cascade
through
several call sites, so they're better addressed when those features are
finished.
### Why are the changes needed?
Removes dead code / build warnings surfaced during CI review.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
`cargo build --release` is clean and all 205 `apache-spark-connect` lib unit
tests pass.
This pull request and its description were written by Isaac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
