cloud-fan commented on PR #58185: URL: https://github.com/apache/spark/pull/58185#issuecomment-5435375223
Thanks @dongjoon-hyun. I addressed these in `2f700fd2f04`: 1. Added a `TODO(SPARK-58628)` at the NULL guards to track eliminating the expression growth. As Holden mentioned above, is it okay to handle this post-merge, or would you prefer SPARK-58628 to land first? 2. Split numeric comparisons into integral and fractional variants. Integral inputs no longer emit `isnan`; Catalyst and PySpark regression tests cover this. 3. Removed the dead string-multiplication categorization and the stale `repeat` comments. Verification passed: `build/sbt -Phive package`, the Catalyst transpilation suite (6/6), the focused PySpark regression test, and the full `pyspark.sql.tests.test_udf_transpile_unit` suite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
