ulysses-you commented on PR #58335: URL: https://github.com/apache/spark/pull/58335#issuecomment-5438976642
Thanks for the review — all feedback addressed in 2b0ef181bc4. Summary: - **1 (title/description):** narrowed the title to the reducer-changes-key-data-type case and rewrote the description: scope is identity-vs-transform and single-side-transform reducers, and the both-sides-reduce shape is called out as a known gap tracked separately. - **2:** per-`KeyedPartitioning` re-targeting in `outputPartitioning` (blocking regression fixed, with a chained-SPJ test). - **3:** shape 2 handled (target transform re-targeted at this side's attribute, guarded by `e2.reducers(e1).isEmpty`); shape 3 intentionally left open. - **4:** multi-table reduce test now exercises the `reduceKeys` trigger without the subset-partition-keys config. - **5/6:** comment narrowed to the applicable branches; `KeyReducer` case class replaces the tuple across all signatures. Tests: `KeyGroupedPartitioningSuite` (108), `EnsureRequirementsSuite` + `GroupPartitionsExecSuite` (45) all pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
