pan3793 commented on PR #58312: URL: https://github.com/apache/spark/pull/58312#issuecomment-5440390726
Thanks for the careful review! 1. Fixed -- reworded to "Use the tracked size if the app was active; otherwise measure it from disk." 2. Reworded to "The store directory is already gone (e.g., deleted out of band)"; kept the branch as a defensive path. 3. Done -- `makeRoom()` now drops the stale listing entry when the directory is already gone. In-process deleters always remove the entry under the same lock, so this branch only fires for out-of-band deletion; `initialize()` already sweeps such orphans at startup, this makes it immediate. 4. Added a note in the description (see the updated PR body). 5. Kept as is: the wait is what keeps the repro deterministic against the old code -- `release()` must be held until `openStore()` completes. In the fixed code `openStore()` is serialized behind the lock `release()` holds, so the latch can only release via the timeout; shortening it would weaken the repro without changing fixed-code coverage. 6. Done -- hoisted to a local val. Backports: yes, SPARK-56044 shipped in 4.0.3/4.1.2/4.2.0, so the race is live there; will backport to branch-4.0/4.1/4.2/4.3/4.x once merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
