nchammas commented on PR #58282:
URL: https://github.com/apache/spark/pull/58282#issuecomment-5440868363
> ```json
> "DELTA_NON_PARTITION_COLUMN_ABSENT" : {
> "message" : [
> "Data written into Delta needs to contain at least one
non-partitioned column."
> ],
> "subClass" : {
> "ALL_PARTITION_COLUMNS" : {
> "message" : [
> "All of the provided columns are partition columns."
> ]
> },
> "NULL_TYPE_COLUMNS_DROPPED" : {
> "message" : [
> "Columns which are of NullType have been dropped."
> ]
> }
> },
> "sqlState" : "KD005"
> },
> ```
I don't see the problem with this setup. To me this reads: "A
non-partitioned column could be absent for a number of reasons. a) The entire
table is partitioned columns. b) There _are_ non-partitioned columns, but they
are of `NullType`."
> ### DELTA_UNSUPPORTED_DROP_COLUMN
> Right now a complex message is hard-coded in the Scala code. We would like
to move it into a subclass in JSON, but we don't want to create an awkward "no
advice" default. Hence, we're blocked by this change.
If the advice is not always applicable, what's wrong with simply leaving it
empty? We already have several error conditions with an optional hint.
Some examples:
-
https://github.com/apache/spark/blob/c3d9631787e82d93cef685d6573e2afddd9ef1f9/common/utils/src/main/resources/error/error-conditions.json#L3160-L3165
-
https://github.com/apache/spark/blob/c3d9631787e82d93cef685d6573e2afddd9ef1f9/python/pyspark/errors/error-conditions.json#L839-L843
-
https://github.com/apache/spark/blob/c3d9631787e82d93cef685d6573e2afddd9ef1f9/common/utils/src/main/resources/error/error-conditions.json#L6180-L6188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
