dongjoon-hyun commented on code in PR #58346:
URL: https://github.com/apache/spark/pull/58346#discussion_r3873338303
##########
core/src/main/scala/org/apache/spark/deploy/master/ui/MasterPage.scala:
##########
@@ -348,7 +366,7 @@ private[ui] class MasterPage(parent: MasterWebUI) extends
WebUIPage("") {
</td>
<td>{UIUtils.formatDate(app.submitDate)}</td>
<td>{app.desc.user}</td>
- <td>{app.state.toString}</td>
+ <td>{appStateText(app)}</td>
Review Comment:
Done in this PR: moved the annotation into `ApplicationInfo.stateText` next
to `numDrainingExecutors`, and both `MasterPage` and `ApplicationPage` render
it now.
##########
core/src/main/scala/org/apache/spark/deploy/client/StandaloneAppClient.scala:
##########
@@ -330,6 +346,17 @@ private[spark] class StandaloneAppClient(
}
}
+ /**
+ * Report to the Master whether this application can be held and whether it
currently is, so
+ * that the Master UI can show the hold status of the application. The
status is cached and
+ * re-sent on failover, so a report made before the registration completes
is not lost.
+ */
+ def reportHoldStatus(supported: Boolean, held: Boolean): Unit = {
+ if (endpoint.get != null) {
Review Comment:
Fixed -- added the warning in the neighbours' shape.
##########
docs/spark-standalone.md:
##########
@@ -711,6 +711,19 @@ holders for server-side environment variables like the
following.
{% endraw %}
```
+# Monitoring Held Applications
Review Comment:
Moved under `# Monitoring and Logging` as a `## Held Applications`
subsection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
