dongjoon-hyun commented on PR #58345: URL: https://github.com/apache/spark/pull/58345#issuecomment-5442224050
Thank you for the review, @peter-toth. All five findings are addressed: - **1** (byte equality finer than grouping equality): fixed in 5e89b10 by keying the partitioner with the partitioning's own `InternalRowComparableWrapper`s on both sides, with a `signed_zeros` regression test — details in the inline reply. - **2** (affected versions / backport): the JIRA now reflects the released lines that carry this bug. - **3** (method naming): the PR description now names the actual locations — the `val part` match inside `ShuffleExchangeExec.prepareShuffleDependency` and its local `getPartitionKeyExtractor`. - **4** (JIRA components): added `Spark Core` alongside `SQL`. - **5** (conf-off arm): both new tests loop both conf states. Could you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
