szehon-ho commented on PR #58370: URL: https://github.com/apache/spark/pull/58370#issuecomment-5459444700
Thanks for another careful pass. Addressed in `ec4fa1afd65`: - Split `DATA_SOURCE_INVALID_RUNTIME_FILTER_ATTRIBUTE` into structured `CANNOT_RESOLVE` and `NOT_TOP_LEVEL` conditions. - Diagnostics now identify the connector method, scan class, and actual relation output; resolution causes remain preserved. - Added coverage for invalid `filterAttributes()` and `fullyPushedFilterAttributes()` declarations. - Documented V1 nested-path encoding and the fully-pushed nested-path limitation. - Group-filter tests now assert the exact nested key path. - Moved the shared DPP regression above the EXPLAIN helper. Validation: 30/30 runtime-filter tests, 2/2 V1/V2 compatibility tests, 37/37 error-catalog tests, and both style checks passed. The error catalog was regenerated; no SQL golden files apply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
