zahed1994 commented on PR #58380: URL: https://github.com/apache/spark/pull/58380#issuecomment-5459900019
Thanks for the review @sunchao! I've updated the PR accordingly: 1. **Fixture stage task count**: Changed `createStageInfo(0, 4)` to `createStageInfo(0, 3)` so there are zero regular pending tasks (`3 running + 0 pending + 1 speculative = 4 total tasks`). Without this fix, `maxNeeded` evaluates to `ceil(4 / 2) = 2`, whereas with this fix, `2 + 1 = 3` triggers, strictly exercising the new allocation path (`base=2 / head=3`). 2. **Scala Linter**: Shortened and wrapped the comment lines so all lines are strictly under 100 characters (max line length 94 chars). All tests and linters are passing cleanly now. Could you please take another look when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
