Nflrijal commented on code in PR #58243:
URL: https://github.com/apache/spark/pull/58243#discussion_r3899491957
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -636,7 +636,9 @@ class SparkContext(config: SparkConf) extends Logging {
}
if (_conf.get(UI_REVERSE_PROXY)) {
- val proxyUrl =
_conf.get(UI_REVERSE_PROXY_URL).getOrElse("").stripSuffix("/")
+ val proxyUrl = _conf.get(UI_REVERSE_PROXY_URL)
+ .getOrElse(sys.props.getOrElse("spark.ui.proxyBase", ""))
Review Comment:
Saved original sys.props value as _previousProxyBase before setting
spark.ui.proxyBase, derived newProxyBase without reading mutated system
properties, and restored the original property in SparkContext.stop(). Added a
unit test in SparkContextSuite covering multi-context initialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
