uros-b commented on PR #58102: URL: https://github.com/apache/spark/pull/58102#issuecomment-5492876710
The fix is targeted and well scoped, reuses the established isDuplicateAgnostic predicate consistently with RemoveRedundantAggregates, and is verified against the JIRA reproduction case as well as the count(*) variant. The three new tests cover the reported scenarios; the broader duplicate-sensitive aggregate class (e.g., non-distinct SUM over a grouping key) also benefits silently from the fix. This should be ready to merge. Adding @cloud-fan who is familiar with Optimizer and EliminateDistinct, to validate reuse of that predicate here and review this PR as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
